Improving the Precision of Fowler's Definitions of Bad Smells

M. Zhang; N. Baddoo; P. Wernick; T. Hall

doi:10.1109/SEW.2008.26

Improving the Precision of Fowler's Definitions of Bad Smells

M. Zhang, N. Baddoo, P. Wernick, T. Hall

Research output: Contribution to journal › Article › peer-review

14 Citations (Scopus)

120 Downloads (Pure)

Abstract

Current approaches to detecting bad smells in code are mainly based on software metrics. We suggest that these methods lack precision in detecting bad smells, and we propose a code pattern-based approach to detecting bad smells. However before such a pattern-based approach can be implemented, Fowler's original definitions of bad smells need to be made more precise. Currently Fowler's definitions are too informal to implement in a pattern-searching tool. In this paper we use an expert panel to evaluate our enhanced definitions for five of Fowler's bad smells. We use a questionnaire to survey four experts' opinions of our bad smell definitions. Our results show that the experts basically agree with our enhanced definitions of the message chains, middle man and speculative generality bad smells. However, there are strong disagreements on our definitions of the data clumps and switch statements bad smells. We present enhanced definitions on the basis of these expert opinions.

Original language	English
Pages (from-to)	161-166
Journal	Proceedings (NASA Goddard/IEEE Software Engineering Workshop)
Volume	2008
DOIs	https://doi.org/10.1109/SEW.2008.26
Publication status	Published - 2009

Access to Document

10.1109/SEW.2008.26

904028.pdf

Cite this

@article{a6fae66eae564e648556b413d1e6f410,

title = "Improving the Precision of Fowler's Definitions of Bad Smells",

abstract = "Current approaches to detecting bad smells in code are mainly based on software metrics. We suggest that these methods lack precision in detecting bad smells, and we propose a code pattern-based approach to detecting bad smells. However before such a pattern-based approach can be implemented, Fowler's original definitions of bad smells need to be made more precise. Currently Fowler's definitions are too informal to implement in a pattern-searching tool. In this paper we use an expert panel to evaluate our enhanced definitions for five of Fowler's bad smells. We use a questionnaire to survey four experts' opinions of our bad smell definitions. Our results show that the experts basically agree with our enhanced definitions of the message chains, middle man and speculative generality bad smells. However, there are strong disagreements on our definitions of the data clumps and switch statements bad smells. We present enhanced definitions on the basis of these expert opinions.",

author = "M. Zhang and N. Baddoo and P. Wernick and T. Hall",

note = "“This material is presented to ensure timely dissemination of scholarly and technical work. Copyright and all rights therein are retained by authors or by other copyright holders. All persons copying this information are expected to adhere to the terms and constraints invoked by each author's copyright. In most cases, these works may not be reposted without the explicit permission of the copyright holder.{"} “Copyright IEEE. Personal use of this material is permitted. However, permission to reprint/republish this material for advertising or promotional purposes or for creating new collective works for resale or redistribution to servers or lists, or to reuse any copyrighted component of this work in other works must be obtained from the IEEE.” DOI: 10.1109/SEW.2008.26",

year = "2009",

doi = "10.1109/SEW.2008.26",

language = "English",

volume = "2008",

pages = "161--166",

journal = "Proceedings (NASA Goddard/IEEE Software Engineering Workshop)",

issn = "1550-6215",

}

TY - JOUR

T1 - Improving the Precision of Fowler's Definitions of Bad Smells

AU - Zhang, M.

AU - Baddoo, N.

AU - Wernick, P.

AU - Hall, T.

N1 - “This material is presented to ensure timely dissemination of scholarly and technical work. Copyright and all rights therein are retained by authors or by other copyright holders. All persons copying this information are expected to adhere to the terms and constraints invoked by each author's copyright. In most cases, these works may not be reposted without the explicit permission of the copyright holder." “Copyright IEEE. Personal use of this material is permitted. However, permission to reprint/republish this material for advertising or promotional purposes or for creating new collective works for resale or redistribution to servers or lists, or to reuse any copyrighted component of this work in other works must be obtained from the IEEE.” DOI: 10.1109/SEW.2008.26

PY - 2009

Y1 - 2009

N2 - Current approaches to detecting bad smells in code are mainly based on software metrics. We suggest that these methods lack precision in detecting bad smells, and we propose a code pattern-based approach to detecting bad smells. However before such a pattern-based approach can be implemented, Fowler's original definitions of bad smells need to be made more precise. Currently Fowler's definitions are too informal to implement in a pattern-searching tool. In this paper we use an expert panel to evaluate our enhanced definitions for five of Fowler's bad smells. We use a questionnaire to survey four experts' opinions of our bad smell definitions. Our results show that the experts basically agree with our enhanced definitions of the message chains, middle man and speculative generality bad smells. However, there are strong disagreements on our definitions of the data clumps and switch statements bad smells. We present enhanced definitions on the basis of these expert opinions.

AB - Current approaches to detecting bad smells in code are mainly based on software metrics. We suggest that these methods lack precision in detecting bad smells, and we propose a code pattern-based approach to detecting bad smells. However before such a pattern-based approach can be implemented, Fowler's original definitions of bad smells need to be made more precise. Currently Fowler's definitions are too informal to implement in a pattern-searching tool. In this paper we use an expert panel to evaluate our enhanced definitions for five of Fowler's bad smells. We use a questionnaire to survey four experts' opinions of our bad smell definitions. Our results show that the experts basically agree with our enhanced definitions of the message chains, middle man and speculative generality bad smells. However, there are strong disagreements on our definitions of the data clumps and switch statements bad smells. We present enhanced definitions on the basis of these expert opinions.

U2 - 10.1109/SEW.2008.26

DO - 10.1109/SEW.2008.26

M3 - Article

SN - 1550-6215

VL - 2008

SP - 161

EP - 166

JO - Proceedings (NASA Goddard/IEEE Software Engineering Workshop)

JF - Proceedings (NASA Goddard/IEEE Software Engineering Workshop)

ER -

Improving the Precision of Fowler's Definitions of Bad Smells

Abstract

Access to Document

Fingerprint

Cite this